When initializing the IPA core clock and interconnects, it's
possible we'll get an EPROBE_DEFER error.  This isn't really an
error, it's just means we need to be re-probed later.

Use dev_err_probe() to report the error rather than dev_err().
This avoids polluting the log with these "error" messages.

Signed-off-by: Alex Elder <el...@linaro.org>
---
v3: - Use dev_err_probe(), as suggested by Heiner Kallweit.
v2: - Update copyright.

 drivers/net/ipa/ipa_clock.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
index 354675a643db5..69ef6ea41e619 100644
--- a/drivers/net/ipa/ipa_clock.c
+++ b/drivers/net/ipa/ipa_clock.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 
 /* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved.
- * Copyright (C) 2018-2020 Linaro Ltd.
+ * Copyright (C) 2018-2021 Linaro Ltd.
  */
 
 #include <linux/refcount.h>
@@ -68,8 +68,8 @@ static int ipa_interconnect_init_one(struct device *dev,
        if (IS_ERR(path)) {
                int ret = PTR_ERR(path);
 
-               dev_err(dev, "error %d getting %s interconnect\n", ret,
-                       data->name);
+               dev_err_probe(dev, ret, "error getting %s interconnect\n",
+                             data->name);
 
                return ret;
        }
@@ -281,7 +281,8 @@ ipa_clock_init(struct device *dev, const struct 
ipa_clock_data *data)
 
        clk = clk_get(dev, "core");
        if (IS_ERR(clk)) {
-               dev_err(dev, "error %ld getting core clock\n", PTR_ERR(clk));
+               dev_err_probe(dev, PTR_ERR(clk), "error getting core clock\n");
+
                return ERR_CAST(clk);
        }
 
-- 
2.20.1

Reply via email to