Try to use the same technique for obtaining skbuff_head from NAPI
cache in {,__}alloc_skb(). Two points here:
 - __alloc_skb() can be used for allocating clones or allocating skbs
   for distant nodes. Try to grab head from the cache only for
   non-clones and for local nodes;
 - can be called from any context, so napi_safe == false.

Signed-off-by: Alexander Lobakin <aloba...@pm.me>
---
 net/core/skbuff.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 8747566a8136..8850086f8605 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -354,15 +354,19 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t 
gfp_mask,
        struct sk_buff *skb;
        u8 *data;
        bool pfmemalloc;
+       bool clone;
 
-       cache = (flags & SKB_ALLOC_FCLONE)
-               ? skbuff_fclone_cache : skbuff_head_cache;
+       clone = !!(flags & SKB_ALLOC_FCLONE);
+       cache = clone ? skbuff_fclone_cache : skbuff_head_cache;
 
        if (sk_memalloc_socks() && (flags & SKB_ALLOC_RX))
                gfp_mask |= __GFP_MEMALLOC;
 
        /* Get the HEAD */
-       skb = kmem_cache_alloc_node(cache, gfp_mask & ~__GFP_DMA, node);
+       if (clone || unlikely(node != NUMA_NO_NODE && node != numa_mem_id()))
+               skb = kmem_cache_alloc_node(cache, gfp_mask & ~GFP_DMA, node);
+       else
+               skb = napi_skb_cache_get(false);
        if (unlikely(!skb))
                return NULL;
        prefetchw(skb);
@@ -393,7 +397,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t 
gfp_mask,
        __build_skb_around(skb, data, 0);
        skb->pfmemalloc = pfmemalloc;
 
-       if (flags & SKB_ALLOC_FCLONE) {
+       if (clone) {
                struct sk_buff_fclones *fclones;
 
                fclones = container_of(skb, struct sk_buff_fclones, skb1);
-- 
2.30.0


Reply via email to