On Tue, Feb 9, 2021 at 12:01 PM Leon Romanovsky <l...@kernel.org> wrote:
>
> On Tue, Feb 09, 2021 at 11:25:33AM +0200, Or Gerlitz wrote:
> > On Tue, Feb 9, 2021 at 8:49 AM Leon Romanovsky <l...@kernel.org> wrote:
> >
> > [..]
> >
> > > This is another problem with mlx5 - complete madness with config options
> > > that are not possible to test.
> > > ➜ kernel git:(rdma-next) grep -h "config MLX"
> > > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | awk '{ print $2}' |
> > > sort |uniq |wc -l
> > > 19
> >
> > wait, why do you call it madness? we were suggested by some users (do
> > git blame for the patches) to refine things with multiple configs and it
> > seem
> > to work quite well -- what you don't like? and what's wrong with simple
> > grep..
>
> Yes, I aware of these users and what and why they asked it.
>
> They didn't ask us to have new config for every feature/file, but to have
> light ethernet device.
>
> Other users are distributions and they enable all options that supported in
> the specific kernel they picked, because they don't know in advance where
> their
> distro will be used.
>
> You also don't have capacity to test various combinations, so you
> test only small subset of common ones that are pretty standard. This is why
> you have this feeling of "work quite well".
ok, point taken
> And I'm not talking about compilations but actual regression runs.
understood
> I suggest to reduce number of configs to small amount, something like 3-5
> options:
> * Basic ethernet driver
> * + ETH
> * + RDMA
> * + VDPA
> * ....
> * Full mlx5 driver
doesn't sound impossible
> And there is nothing wrong with simple grep [..]
no worries
