Cong Wang wrote: > From: Cong Wang <cong.w...@bytedance.com> > > I was planning to reuse BPF_SK_SKB_STREAM_VERDICT but its name is > confusing and more importantly it seems kTLS relies on it to deliver > sk_msg too. To avoid messing up kTLS, we can just reuse the stream > verdict code but introduce a new type of eBPF program, skb_verdict. > Users are not allowed to set stream_verdict and skb_verdict at the > same time. > > Cc: John Fastabend <john.fastab...@gmail.com> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: Jakub Sitnicki <ja...@cloudflare.com> > Cc: Lorenz Bauer <l...@cloudflare.com> > Signed-off-by: Cong Wang <cong.w...@bytedance.com>
I think it will be better if we can keep the same name. Does it break kTLS somehow? I'm not seeing it with a quick scan. We can always alias a better name with the same value for readability.