On Fri, May 25, 2007 at 08:50:20AM +0200, Eric Dumazet wrote: > > If this patch really helps, this means cond_resched_softirq() > doesnt work at all and should be fixed, or just zapped as it > is seldom used.
cond_resched_softirq lets other threads run if they want to. It doesn't run pending softirq's at all. In fact, it doesn't even wake up ksoftirqd. So if the only work we get come from softirq's then we'll just block them until we're done with /proc/net/tcp. You can (correctly) argue that cond_resched_softirq is broken, but it doesn't change the fact that we don't even need to call it for /proc/net/tcp. This patch simply changes /proc/net/tcp to be in line with the behaviour of inet_diag. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
