On Thu, Feb 04, 2021 at 11:50:53PM +0800, wenxu wrote: > > 在 2021/2/4 21:38, Marcelo Ricardo Leitner 写道: > > Hi, > > > > On Thu, Feb 04, 2021 at 12:17:24PM +0800, we...@ucloud.cn wrote: > >> From: wenxu <we...@ucloud.cn> > >> > >> Reject the unknown ct_state flags of cls flower rules. This also make > >> the userspace like ovs to probe the ct_state flags support in the > >> kernel. > > That's a good start but it could also do some combination sanity > > checks, like ovs does in validate_ct_state(). For example, it does: > > > > if (state && !(state & CS_TRACKED)) { > > ds_put_format(ds, "%s: invalid connection state: " > > "If \"trk\" is unset, no other flags are set\n", > > > So this sanity checks maybe also need to be added in the ovs kernel modules? > > The kernel datapath can work without ovs-vswitchd.
IMHO that would be nice, yes. Marcelo