In gsi_channel_setup(), we check to see if the configuration data
contains any information about channels that are not supported by
the hardware.  If one is found, we abort the setup process, but
the error code (ret) is not set in this case.  Fix this bug.

Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Alex Elder <el...@linaro.org>
---
 drivers/net/ipa/gsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 34e5f2155d620..b77f5fef7aeca 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1710,6 +1710,7 @@ static int gsi_channel_setup(struct gsi *gsi)
                if (!channel->gsi)
                        continue;       /* Ignore uninitialized channels */
 
+               ret = -EINVAL;
                dev_err(gsi->dev, "channel %u not supported by hardware\n",
                        channel_id - 1);
                channel_id = gsi->channel_count;
-- 
2.20.1

Reply via email to