On Wed, Feb 03, 2021 at 12:56:35AM -0800, Sagi Grimberg wrote: > >>> Given how much ddp code there is can you split it into a separate file? >> >> mmm, do we need to check the preferences or get to a consensus among >> the maintainers for that one? > > Not sure if moving it would be better here. Given that the ddp code is > working directly on nvme-tcp structs we'll need a new shared header > file.. > > Its possible to do, but I'm not sure the end result will be better..
In the end its your code base. But I hate having all this offload cruft all over the place. Just saying no to offloads might be an even better position, though.
