On Mon, 1 Feb 2021 09:32:15 +0800 Chris Mi wrote: > On 1/30/2021 2:59 PM, Jakub Kicinski wrote: > > On Sat, 30 Jan 2021 10:33:19 +0800 Chris Mi wrote: > >> +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB > >> +/* Copyright (c) 2021 Mellanox Technologies. */ > >> + > >> +const struct psample_ops __rcu *psample_ops __read_mostly; > >> +EXPORT_SYMBOL_GPL(psample_ops); > > Please explain to me how you could possibly have compile tested this > > and not caught that it doesn't build. > Sorry, I don't understand which issue you are talking about. Do you mean > the issue sparse found before or new issues in v5?
There is no include here now, and it uses EXPORT_SYMBOL_GPL() and a bunch of decorators.