Re: [PATCH net 2/2] ibmvnic: fix race with multiple open/close

[Willem de Bruijn]

On Thu, Jan 28, 2021 at 10:51 PM Sukadev Bhattiprolu
<suka...@linux.ibm.com> wrote:
>
> If two or more instances of 'ip link set' commands race and first one
> already brings the interface up (or down), the subsequent instances
> can simply return without redoing the up/down operation.
>
> Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> Reported-by: Abdul Haleem <abdha...@in.ibm.com>
> Tested-by: Abdul Haleem <abdha...@in.ibm.com>
> Signed-off-by: Sukadev Bhattiprolu <suka...@linux.ibm.com>

Isn't this handled in the rtnetlink core based on IFF_UP?

        if ((old_flags ^ flags) & IFF_UP) {
                if (old_flags & IFF_UP)
                        __dev_close(dev);
                else
                        ret = __dev_open(dev, extack);
        }