On Fri, Jan 29, 2021 at 2:30 PM Vadim Fedorenko <vfedore...@novek.ru> wrote:
>
> dev->hard_header_len for tunnel interface is set only when header_ops
> are set too and already contains full overhead of any tunnel encapsulation.
> That's why there is not need to use this overhead twice in mtu calc.
>
> Fixes: fdafed459998 ("ip_gre: set dev->hard_header_len and
> dev->needed_headroom properly")
> Reported-by: Slava Bacherikov <m...@slava.cc>
> Signed-off-by: Vadim Fedorenko <vfedore...@novek.ru>
I have no objection, just please double check this does not break
other IP tunnels as you touch the core ip tunnel code, especially
those using ip_tunnel_header_ops.
Thanks.
