On Mon, May 21, 2007 at 06:16:35PM -0400, Dave Jones wrote: > On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote: > > Herbert Xu wrote: > > "netif_poll_enable can only be called if you've previously called > > netif_poll_disable. Otherwise a poll might already be in action > > and you may get a crash like this." > > > > Removing the call to netif_poll_enable in e1000_open should fix this issue, > > the only other call to netif_poll_enable is in e1000_up() which is only > > reached after a device reset or resume. > > > > Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455 > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339 > > This probably doesn't solve the latter bug. > The code you reference isn't there in the kernel tested in that bug > (2.6.21) In 2.6.21, netif_poll_enable is only called from > e1000_up(), not e1000_open()
Yes we need a different fix for 2.6.21. There e1000_open calls e1000_up which is why we still get the netif_poll_enable. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
