David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Sat, 19 May 2007 21:47:00 -0400
According to the implementation, netif_rx() can fail.

It doesn't exactly "fail", but it does give return values
which indicate RX congestion.

Assuming you're referring to NET_RX_CN_*, this doesn't seem to be the case anymore: it appears netif_rx can only return NET_RX_SUCCESS or NET_RX_DROP.

The congestion level constants are hardly used at all - if they are left-overs, would it make sense ripping them out completely?

Either way I believe the following should be OK:


Remove inaccurate netif_rx() return value comments.

Signed-off-by: Florin Malita <[EMAIL PROTECTED]>
---

dev.c |    3 ---
1 file changed, 3 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index f2b6111..79f5d90 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1628,9 +1628,6 @@ DEFINE_PER_CPU(struct netif_rx_stats, netdev_rx_stat) = { 
0, };
 *
 *      return values:
 *      NET_RX_SUCCESS  (no congestion)
- *     NET_RX_CN_LOW   (low congestion)
- *     NET_RX_CN_MOD   (moderate congestion)
- *     NET_RX_CN_HIGH  (high congestion)
 *      NET_RX_DROP     (packet was dropped)
 *
 */

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to