On Wed, Jan 20, 2021 at 3:21 AM Danielle Ratson <daniel...@nvidia.com> wrote:
> + link_ksettings->link_mode = -1;
> + err = dev->ethtool_ops->get_link_ksettings(dev, link_ksettings);
> + if (err)
> + return err;
> +
> + if (link_ksettings->link_mode != -1) {
> + link_info = &link_mode_params[link_ksettings->link_mode];
> + link_ksettings->base.speed = link_info->speed;
> + link_ksettings->lanes = link_info->lanes;
> + link_ksettings->base.duplex = link_info->duplex;
> + }
Why isn't this also handled using a capability bit as is done for
lanes? Is link_mode read-only? Should it / will it always be? If not,
can drivers also derive the other fields if asked to set link_mode?
That would be easy enough. Why don't we simply allow user space to set
link mode directly too (in addition to being able to constrain lanes
for autoneg or forced speeds)?
Regards,
Edwin Peer
smime.p7s
Description: S/MIME Cryptographic Signature
