Hi Bjørn,
On Mon, Jan 18, 2021 at 10:02 PM Bjørn Mork <bj...@mork.no> wrote:
>
> Reinhard Speyerer <rs...@t-online.de> writes:
>
> >> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> >> index af19513a9f75..262d19439b34 100644
> >> --- a/drivers/net/usb/qmi_wwan.c
> >> +++ b/drivers/net/usb/qmi_wwan.c
> >> @@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
> >> {QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)}, /* Olivetti Olicard 160 */
> >> {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */
> >> {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
> >> + {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)}, /* Cinterion PLS83/PLS63 */
> >> + {QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
> >> {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */
> >> {QMI_FIXED_INTF(0x1e2d, 0x0063, 10)}, /* Cinterion ALASxx (1 RmNet)
> >> */
> >> {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2
> >> RmNet) */
> >
> > Hi Giacinto,
> >
> > AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply
> > be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8
> > ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> > and commit 97dc47a1308a3af46a09b1546cfb869f2e382a81
> > ("qmi_wwan: apply SET_DTR quirk to Sierra WP7607") for the corresponding
> > examples from other UE vendors.
>
> Yup, please fix and send a v2. And please use get_maintainer.pl to get
> the proper destinations.
>
I have fixed and resent, but from your comment I might not have
selected the right line from maintaner.pl?
what I have is this:
$ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c
"Bjørn Mork" <bj...@mork.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
"David S. Miller" <da...@davemloft.net> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <k...@kernel.org> (maintainer:NETWORKING DRIVERS)
netdev@vger.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
<<<< this seems the right one
linux-...@vger.kernel.org (open list:USB NETWORKING DRIVERS)
linux-ker...@vger.kernel.org (open list)
I have at the same time sent a patch for another enumeration of the
same product, for cdc_ether. In that case, I have picked the
following line, which also looked the best fit:
linux-...@vger.kernel.org (open list:USB CDC ETHERNET DRIVER)
Did I misinterpret the results of the script?
Thank you,
Giacinto
