On Sat, Jan 16, 2021 at 01:12:48AM +0200, Vladimir Oltean wrote: > On Fri, Jan 15, 2021 at 03:03:14PM -0800, Jakub Kicinski wrote: > > On Thu, 14 Jan 2021 19:34:26 +0200 Vladimir Oltean wrote: > > > From: Vladimir Oltean <vladimir.olt...@nxp.com> > > > > > > As explained in commit 54a0ed0df496 ("net: dsa: provide an option for > > > drivers to always receive bridge VLANs"), DSA has historically been > > > skipping VLAN switchdev operations when the bridge wasn't in > > > vlan_filtering mode, but the reason why it was doing that has never been > > > clear. So the configure_vlan_while_not_filtering option is there merely > > > to preserve functionality for existing drivers. It isn't some behavior > > > that drivers should opt into. Ideally, when all drivers leave this flag > > > set, we can delete the dsa_port_skip_vlan_configuration() function. > > > > No longer applies :( > > What's the error?
Never mind, I know what happened. It rebased cleanly just because git is smart. I'll resend a v2 with the updated context.