On Fri, Jan 15, 2021 at 03:48:36PM +0100, Andrew Lunn wrote: > On Fri, Jan 15, 2021 at 04:36:49PM +0200, Vladimir Oltean wrote: > > On Fri, Jan 15, 2021 at 03:30:30PM +0100, Andrew Lunn wrote: > > > On Fri, Jan 15, 2021 at 11:58:33AM +0100, Tobias Waldekranz wrote: > > > > Support for Global 2 registers is build-time optional. > > > > > > I was never particularly happy about that. Maybe we should revisit > > > what features we loose when global 2 is dropped, and see if it still > > > makes sense to have it as optional? > > > > Marvell switch newbie here, what do you mean "global 2 is dropped"? > > I was not aware detect() actually enforced it when needed. It used to > be, you could leave it out, and you would just get reduced > functionality for devices which had global2, but the code was not > compiled in. > > At the beginning of the life of this driver, i guess it was maybe > 25%/75% without/with global2, so it might of made sense to reduce the > binary size. But today the driver is much bigger with lots of other > things which those early chips don't have, SERDES for example. And > that ratio has dramatically reduced, there are very few devices > without those registers. This is why i think we can make our lives > easier and make global2 always compiled in.
That makes sense, I thought you meant something else by "global 2 support is dropped", nevermind.
