Re: [Patch net v3] cls_flower: call nla_ok() before nla_next()

[Jakub Kicinski]

On Thu, 14 Jan 2021 13:07:49 -0800 Cong Wang wrote:
> -                     if (msk_depth)
> -                             nla_opt_msk = nla_next(nla_opt_msk, &msk_depth);
>                       break;
>               default:
>                       NL_SET_ERR_MSG(extack, "Unknown tunnel option type");
>                       return -EINVAL;
>               }
> +
> +             if (!nla_opt_msk)
> +                     continue;

Why the switch from !msk_depth to !nla_opt_msk?

Seems like previously providing masks for only subset of options 
would have worked.