Jakub Kicinski <[email protected]> wrote: > On Tue, 12 Jan 2021 15:59:15 +0000 David Howells wrote: > > From: Baptiste Lepers <[email protected]> > > > > The call state may be changed at any time by the data-ready routine in > > response to received packets, so if the call state is to be read and acted > > upon several times in a function, READ_ONCE() must be used unless the call > > state lock is held. > > > > As it happens, we used READ_ONCE() to read the state a few lines above the > > unmarked read in rxrpc_input_data(), so use that value rather than > > re-reading it. > > > > Signed-off-by: Baptiste Lepers <[email protected]> > > Signed-off-by: David Howells <[email protected]> > > Fixes: a158bdd3247b ("rxrpc: Fix call timeouts") > > maybe?
Ah, yes. I missed there wasn't a Fixes line. Can you add that one in, or do I need to resubmit the patch? David
