On 1/11/21 5:15 PM, Jakub Kicinski wrote:
>> diff --git a/tools/testing/selftests/net/nettest.c
>> b/tools/testing/selftests/net/nettest.c
>> index 0e4196027d63..13c74774e357 100644
>> --- a/tools/testing/selftests/net/nettest.c
>> +++ b/tools/testing/selftests/net/nettest.c
>> @@ -1705,9 +1705,27 @@ static char *random_msg(int len)
>>
>> static int ipc_child(int fd, struct sock_args *args)
>> {
>> + char *outbuf, *errbuf;
>> + int rc;
>> +
>> + outbuf = malloc(4096);
>> + errbuf = malloc(4096);
>> + if (!outbuf || !errbuf) {
>> + fprintf(stderr, "server: Failed to allocate buffers for stdout
>> and stderr\n");
>> + return 1;
>
> that's a memleak, rc = 1, goto free; ?
>
> Also there's a few uses of fprintf(stderr, .. instead of log_error()
> is there a reason for it?
>
> I don't think this is a big deal, I'll apply unless you object in time.
>
good catch. I found a bug in patch 5 as well. I'll fix and re-send.
