On 1/8/2021 4:01 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.olt...@nxp.com>
>
> As of commit 457e20d65924 ("mlxsw: spectrum_switchdev: Avoid returning
> errors in commit phase"), the mlxsw driver performs the VLAN object
> offloading during the prepare phase. So conversion just seems to be a
> matter of removing the code that was running in the commit phase.
>
> Ido Schimmel explains that the reason why mlxsw_sp_span_respin is called
> unconditionally is because the bridge driver will ignore -EOPNOTSUPP and
> actually add the VLAN on the bridge device - see commit 9c86ce2c1ae3
> ("net: bridge: Notify about bridge VLANs") and commit ea4721751977
> ("mlxsw: spectrum_switchdev: Ignore bridge VLAN events"). Since the VLAN
> was successfully added on the bridge device, mlxsw_sp_span_respin_work()
> should be able to resolve the egress port for a packet that is mirrored
> to a gre tap and passes through the bridge device. Therefore keep the
> logic as it is.
>
> Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>
> Acked-by: Linus Walleij <linus.wall...@linaro.org>
> Acked-by: Jiri Pirko <j...@nvidia.com>
> Reviewed-by: Ido Schimmel <ido...@nvidia.com>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
--
Florian
