On Fri, 2007-11-05 at 15:01 -0700, Waskiewicz Jr, Peter P wrote:
> The current requeue calls in qdisc_restart() returns a value of 1 to the
> upper layer.
Which was not meaningful ;->
i.e qdisc run would break as a result.
Note, this is still in conformance with net-2.6 based on a change in the
last few days made by Herbert - I was following his lead.
I put that comment there just as something to remember and
maybe revisit later.
> If you return 0, the __qdisc_run() won't break from the
> while() it seems if you have to successfully requeue a packet.
>
It wont; the check is for < 0
>
> -static inline int qdisc_restart(struct net_device *dev)
> +int
> +qdisc_restart(struct net_device *dev)
> {
>
> Why is this no longer defined static?
>
Good catch - i will restore it to what it was originally.
>
> + /* we need to refresh q because it may be invalid since we
> droped
>
> <nitpick>
> droped = dropped
> </nitpick>
>
Ok, better to fix it now before the spelling police show up ;->
> That's all I have for now. I'll try applying it for kicks and see what
> happens.
Just make those two fixes in your version; also note, you need Davems
net-2.6 tree.
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
