> -int usbnet_get_link_ksettings(struct net_device *net,
> +/* These methods are written on the assumption that the device
> + * uses MII
> + */
> +int usbnet_get_link_ksettings_mdio(struct net_device *net,
>                             struct ethtool_link_ksettings *cmd)

Hi Oliver

I would prefer this was called usbnet_get_link_ksettings_mii, since
this is using the old mii framework, not phylib and mdio drivers.  I
believe there are some USB drivers which do use mdio drivers and
phylib, and we should try to avoid getting things confused.

        Andrew

Reply via email to