On Tue, Jan 05, 2021 at 05:38:33PM +0100, Marek Behún wrote: > The error message says that "Jumbo frames are not supported on XDP", but > the code checks for mtu > MVNETA_MAX_RX_BUF_SIZE, not mtu > 1500. > > Fix this error message. > > Signed-off-by: Marek Behún <ka...@kernel.org> > Fixes: 0db51da7a8e9 ("net: mvneta: add basic XDP support") > Cc: Lorenzo Bianconi <lore...@kernel.org> > Cc: Thomas Petazzoni <thomas.petazz...@bootlin.com> > --- > drivers/net/ethernet/marvell/mvneta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c > b/drivers/net/ethernet/marvell/mvneta.c > index 563ceac3060f..8adbfa25465d 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -4432,7 +4432,7 @@ static int mvneta_xdp_setup(struct net_device *dev, > struct bpf_prog *prog, > struct bpf_prog *old_prog; > > if (prog && dev->mtu > MVNETA_MAX_RX_BUF_SIZE) { > - NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not supported on XDP"); > + NL_SET_ERR_MSG_MOD(extack, "XDP is not supported with MTU > > %d", dev->mtu); > return -EOPNOTSUPP;
Hi Marek In addition to the OMG, don't you actually want to print MVNETA_MAX_RX_BUF_SIZE, not the dev->mtu? Andrew