David Ahern <[email protected]> writes:
> On 12/23/20 11:25 AM, Petr Machata wrote:
>> diff --git a/dcb/dcb.c b/dcb/dcb.c
>> index a59b63ac9159..e6cda7337924 100644
>> --- a/dcb/dcb.c
>> +++ b/dcb/dcb.c
>> @@ -467,7 +467,8 @@ static void dcb_help(void)
>> " dcb [ -f | --force ] { -b | --batch } filename [ -N |
>> --Netns ] netnsname\n"
>> "where OBJECT := { buffer | ets | maxrate | pfc }\n"
>> " OPTIONS := [ -V | --Version | -i | --iec | -j |
>> --json\n"
>> - " | -p | --pretty | -s | --statistics | -v |
>> --verbose]\n");
>> + " | -n | --no-nice-names | -p | --pretty\n"
>
>
> iproute2 commands really should have a consistent user interface.
> Unfortunately -N and -n are inconsistent with the newer commands like
> devlink. dcb has not been released yet so time to fix this.
>
> devlink is the only one using the horribly named 'no-nice-names', and we
> should avoid propagating that to dcb. At a minimum it should be
> 'numeric' which is consistent with the others.
>
> My preference is also to have dcb follow ip and tc (vs ss) with '-n' to
> mean -netns and -N' to mean numeric.
Agreed on all counts.
