From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 10 May 2007 22:53:04 +1000
> [NET_SCHED]: Avoid requeue warning on dev_deactivate > > When we relinquish queue_lock in qdisc_restart and then retake it for > requeueing, we might race against dev_deactivate and end up requeueing > onto noop_qdisc. This causes a warning to be printed. > > This patch fixes this by checking this before we requeue. As an added > bonus, we can remove the same check in __qdisc_run which was added to > prevent dev->gso_skb from being requeued when we're shutting down. > > Even though we've had to add a new conditional in its place, it's better > because it only happens on requeues rather than every single time that > qdisc_run is called. > > For this to work we also need to move the clearing of gso_skb up in > dev_deactivate as now qdisc_restart can occur even after we wait for > __LINK_STATE_QDISC_RUNNING to clear (but it won't do anything as long > as the queue and gso_skb is already clear). > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Looks good, applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
