Hi Andrew,

> From: Andrew Jeffery <and...@aj.id.au>
> 
> > Fix AST2600 EVB NCSI RX timeout issue by removing 
> > FTGMAC100_RXDES0_RX_ERR bit from macro RXDES0_ANY_ERROR.
> 
> But why? What is wrong with the EVB that this change resolves? Which revision 
> of the EVB?
> 
> The change affects all designs using the MAC, not just the AST2600 EVB. Why 
> is this patch an 
> appropriate course of action? Can we not add a quirk targeting the specific 
> board (e.g. a devicetree 
> property)?

You are correct. I was in a rush and didn't put this patch under whole picture 
of the driver it affected. I revised the cover letter with more information, 
also
use a configurable flag to isolate the change. please review the new approach.

> 
> Andrew
> 
Thanks,
--Hongwei

Reply via email to