RE: [net-next v5 11/15] net/mlx5: SF, Add port add delete functionality

[Parav Pandit]

> From: Jakub Kicinski <k...@kernel.org>
> Sent: Wednesday, December 16, 2020 6:21 AM
> 
> On Tue, 15 Dec 2020 01:03:54 -0800 Saeed Mahameed wrote:
> > To handle SF port management outside of the eswitch as independent
> > software layer, introduce eswitch notifier APIs so that upper layer
> > who wish to support sf port management in switchdev mode can perform
> > its
> 
> Could you unpack this? What's the "upper layer" software in this context?
>
Upper layer in this context = sf management layer within the mlx5 driver which 
implements devlink port add/del callbacks and state handling.
 
> > task whenever eswitch mode is set to switchdev or before eswitch is
> > disabled.
> 
> How does SF work if eswich is disabled?
> 
It doesn't.
when eswitch is disabled, all SF ports gets destroyed through the eswitch event 
notifier.

> > Initialize sf port table on such eswitch event.
> >
> > Add SF port add and delete functionality in switchdev mode.
> > Destroy all SF ports when eswitch is disabled.
> > Expose SF port add and delete to user via devlink commands.