On Wed,  9 Dec 2020 00:18:11 -0600 Lijun Pan wrote:
> Start to use the lockless version of netdev_notify_peers.
> 
> Cc: Haiyang Zhang <haiya...@microsoft.com>
> Signed-off-by: Lijun Pan <l...@linux.ibm.com>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index d17bbc75f5e7..4e3dac7bb944 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -2130,10 +2130,10 @@ static void netvsc_link_change(struct work_struct *w)
>               break;
>       }
>  
> -     rtnl_unlock();
> -
>       if (notify)
> -             netdev_notify_peers(net);
> +             __netdev_notify_peers(net);
> +
> +     rtnl_unlock();

Looks like this code is only using this "notify" variable because it
wanted to wait until unlock to call the function. I think you can now
just call the helper where notify used to be set to true.

Reply via email to