David Miller <[EMAIL PROTECTED]> wrote on 05/09/2007 12:06:30 PM: > But this only makes sense for the second hunk you changed.
I think it should work fine for both. > The first hunk is a bug case, an improper looping device > decapsulation condition, and we do want to always return > -1 in that case in order to break out of the loop. I guess you meant "we do *not* want to always return -1" ? > Your change will make the kernel essentially hang instead > when this bug check is triggered. By returning -1, we end up freeing all the skbs one by one, or until the condition : "transient error caused by hard_start_xmit recursing" is over. Essentially, that behavior is also not changed in my patch (only run time change is to return 0 if there are no more skbs). Thanks, - KK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
