On Thu, Dec 3, 2020 at 9:55 PM Cong Wang <xiyou.wangc...@gmail.com> wrote: > > On Thu, Dec 3, 2020 at 10:30 AM Alexei Starovoitov > <alexei.starovoi...@gmail.com> wrote: > > > > On Thu, Dec 3, 2020 at 10:28 AM Cong Wang <xiyou.wangc...@gmail.com> wrote: > > > > > > On Thu, Dec 3, 2020 at 10:22 AM Alexei Starovoitov > > > <alexei.starovoi...@gmail.com> wrote: > > > > > > > > I guess my previous comment could be misinterpreted. > > > > Cong, > > > > please respin with changing preempt_disable to migrate_disable > > > > and adding local_bh_disable. > > > > > > I have no objection, just want to point out migrate_disable() may > > > not exist if we backport this further to -stable, this helper was > > > introduced in Feb 2020. > > > > I see. Then please split it into two patches for ease of backporting. > > You mean the first patch does the same as this patch and the second > patch replaces preempt_disable() with migrate_disable(). Right?
Right. Just be mindful of changing the comment.
