On Fri, 4 Dec 2020 10:35:07 -0800 Cong Wang wrote: > On Thu, Dec 3, 2020 at 10:41 AM Davide Caratti <dcara...@redhat.com> wrote: > > > > with the following tdc testcase: > > > > 83be: (qdisc, fq_pie) Create FQ-PIE with invalid number of flows > > > > as fq_pie_init() fails, fq_pie_destroy() is called to clean up. Since the > > timer is not yet initialized, it's possible to observe a splat like this: > ... > > fix it moving timer_setup() before any failure, like it was done on 'red' > > with former commit 608b4adab178 ("net_sched: initialize timer earlier in > > red_init()"). > > > > Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler") > > Signed-off-by: Davide Caratti <dcara...@redhat.com> > > Reviewed-by: Cong Wang <cong.w...@bytedance.com>
Applied, thanks!