On 12/4/20 3:57 PM, Oleksij Rempel wrote: [...]
> +static void ar9331_sw_irq_bus_sync_unlock(struct irq_data *d)
> {
> struct ar9331_sw_priv *priv = irq_data_get_irq_chip_data(d);
> struct regmap *regmap = priv->regmap;
> int ret;
>
> ret = regmap_update_bits(regmap, AR9331_SW_REG_GINT_MASK,
> - AR9331_SW_GINT_PHY_INT,
> - AR9331_SW_GINT_PHY_INT);
> + AR9331_SW_GINT_PHY_INT, priv->irq_mask);
> if (ret)
> - dev_err(priv->dev, "could not unmask IRQ\n");
> + dev_err(priv->dev, "could not mask IRQ\n");
Technically this could be a mask or unmask operation. What about changing the
error message to: "faild to change IRQ mask"?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: OpenPGP digital signature
