On Wed, 2 Dec 2020 12:28:47 +0100 Thomas Karlsson wrote:
> >> + if (vlan->bc_queue_len_requested > max_bc_queue_len_requested)
> >> + max_bc_queue_len_requested =
> >> vlan->bc_queue_len_requested;
> >> + }
> >> + port->bc_queue_len_used = max_bc_queue_len_requested;
> >> +}
> >> +
> >> static int macvlan_device_event(struct notifier_block *unused,
> >> unsigned long event, void *ptr)
> >> {
>
> I also noticed I got a few line length warnings in patchworks but none when I
> ran the ./scrips/checkpatch.pl
> locally. So is the net tree using strict 80 chars? I would prefer not to
> introduce extra line breaks
> on those lines as I think it will hurt readability but of course I will if
> needed.
I run checkpatch with --max-line-length=80, I think the 80 char
limitation is quite reasonable and leads to more readable code.
In your case I'd do s/bc_queue_len_requested/bc_queue_len_req/.
But it's up to you.
