Hi Andrew, On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn <and...@lunn.ch> wrote: > > On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > > Add support for RGMII in 100 and 1000 Mbps. > > > > Adjust the CPU port settings from the host interface settings: interface > > MII type, speed, duplex. > > Hi Jean > > You have still not explained why this is needed. Why? is always the > important question to answer in the commit message. The What? is > obvious from reading the patch. Why does you board need this, when no > over board does?
I reworked the commit description about the What and thought it was enough. Do you need a cover letter to describe it more? The Why is: " Configure the host port of the switch to match the host interface settings. This is useful when the switch is directly connected to the host MAC interface. " Thank you for reviewing the patch. BR, Jean > > Thanks > Andrew
