Hi Marc, > -----Original Message----- > From: Marc Zyngier <m...@kernel.org> > Sent: Tuesday, November 24, 2020 5:07 PM > To: Jianyong Wu <jianyong...@arm.com> > Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com; > richardcoch...@gmail.com; Mark Rutland <mark.rutl...@arm.com>; > w...@kernel.org; Suzuki Poulose <suzuki.poul...@arm.com>; Andre > Przywara <andre.przyw...@arm.com>; Steven Price > <steven.pr...@arm.com>; linux-ker...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; kvm...@lists.cs.columbia.edu; > k...@vger.kernel.org; Steve Capper <steve.cap...@arm.com>; Justin He > <justin...@arm.com>; nd <n...@arm.com> > Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp. > > On 2020-11-24 05:20, Jianyong Wu wrote: > > Hi Marc, > > [...] > > >> > +/* ptp_kvm counter type ID */ > >> > +#define ARM_PTP_VIRT_COUNTER 0 > >> > +#define ARM_PTP_PHY_COUNTER 1 > >> > +#define ARM_PTP_NONE_COUNTER 2 > >> > >> The architecture definitely doesn't have this last counter. > > > > Yeah, this is just represent no counter data needed from guest. > > Some annotation should be added here. > > I'd rather you remove it entirely, or explain why you really cannot do without > a fake counter.
OK, I will remove it. Thanks Jianyong > > M. > -- > Jazz is not dead. It just smells funny...
