Mon, Nov 23, 2020 at 03:49:06AM CET, gcher...@marvell.com wrote: > > >> -----Original Message----- >> From: Jiri Pirko <j...@resnulli.us> >> Sent: Saturday, November 21, 2020 7:44 PM >> To: George Cherian <gcher...@marvell.com> >> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; >> k...@kernel.org; da...@davemloft.net; Sunil Kovvuri Goutham >> <sgout...@marvell.com>; Linu Cherian <lcher...@marvell.com>; >> Geethasowjanya Akula <gak...@marvell.com>; masahi...@kernel.org; >> willemdebruijn.ker...@gmail.com; sa...@kernel.org >> Subject: Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health >> reporters for NPA >> >> Sat, Nov 21, 2020 at 05:02:00AM CET, george.cher...@marvell.com wrote: >> >Add health reporters for RVU NPA block. >> >NPA Health reporters handle following HW event groups >> > - GENERAL events >> > - ERROR events >> > - RAS events >> > - RVU event >> >An event counter per event is maintained in SW. >> > >> >Output: >> > # devlink health >> > pci/0002:01:00.0: >> > reporter npa >> > state healthy error 0 recover 0 >> > # devlink health dump show pci/0002:01:00.0 reporter npa >> > NPA_AF_GENERAL: >> > Unmap PF Error: 0 >> > Free Disabled for NIX0 RX: 0 >> > Free Disabled for NIX0 TX: 0 >> > Free Disabled for NIX1 RX: 0 >> > Free Disabled for NIX1 TX: 0 >> >> This is for 2 ports if I'm not mistaken. Then you need to have this reporter >> per-port. Register ports and have reporter for each. >> >No, these are not port specific reports. >NIX is the Network Interface Controller co-processor block. >There are (max of) 2 such co-processor blocks per SoC.
Ah. I see. In that case, could you please structure the json differently. Don't concatenate the number with the string. Instead of that, please have 2 subtrees, one for each NIX. > >Moreover, this is an NPA (Network Pool/Buffer Allocator co- processor) >reporter. >This tells whether a free or alloc operation is skipped due to the >configurations set by >other co-processor blocks (NIX,SSO,TIM etc). > >https://www.kernel.org/doc/html/latest/networking/device_drivers/ethernet/marvell/octeontx2.html >> NAK.
