I looked at this yesterday and got distracted diving into the generated
file to see the difference:

#define CONFIG_IPV6 1

vs

#define CONFIG_IPV6_MODULE 1

Digging up ancient history. ;)

Interesting.

drivers/net/ethernet/netronome/nfp/flower/action.c:#ifdef CONFIG_IPV6

Oops.

Notify the maintainer!

Yeah, this is super scary stuff - allmodyes-like configs are quite
common in generic distros, and I assume similar mistakes could have
happened in many other places in the kernel as well.

I wonder if the "ifdef CONFIG_…" pattern should be discouraged, and
"IS_ENABLED(CONFIG_…)" used instead, at least for all tristate config
options.

Florian

Reply via email to