On Mon, Nov 16, 2020 at 05:07:37PM -0800, Jakub Kicinski wrote: > On Fri, 13 Nov 2020 16:10:54 -0800 Tony Nguyen wrote:
> > +/* get PTP pins for ioctl */ > > +#define SIOCGPINS (SIOCDEVPRIVATE + 0) > > +/* set PTP pins for ioctl */ > > +#define SIOCSPINS (SIOCDEVPRIVATE + 1) > > This is unexpected.. is it really normal to declare private device > IOCTLs to configure PPS pins? Or are you just exposing this so you're > able to play with GPIOs from user space? I missed the full patch, but I'd like to point out that we already have a rather fully featured pin control API. If something is missing from that API, then please, let's discuss it! Thanks, Richard
