Re: [PATCH] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

[Florian Fainelli]

On 11/10/2020 1:13 AM, Tobias Waldekranz wrote:
> Ethertype DSA encodes exactly the same information in the DSA tag as
> the non-ethertype variety. So refactor out the common parts and reuse
> them for both protocols.
> 
> This is ensures tag parsing and generation as always consistent across
> all mv88e6xxx chips.

s/as/is/?

This looks good to me! This made me remember that we do not really
interface with devlink traps today in DSA, but we may be able to.
-- 
Florian