When we determine from hardware what the size of IPA memory is
we compare it against what we learned about it from DT.

If DT defines a region that's larger than actual memory, we use the
smaller actual size and issue a warning.

If DT defines a smaller region than actual memory we issue a warning
too.  But in this case the difference is harmless; so rather than
issuing a warning, just provide a debug message instead.

Reorder these checks so the one that matters more is done first.

Reported-by: Stephen Boyd <swb...@chromium.org>
Signed-off-by: Alex Elder <el...@linaro.org>
---
 drivers/net/ipa/ipa_mem.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c
index ecfd1f91fce3b..0cc3a3374caa2 100644
--- a/drivers/net/ipa/ipa_mem.c
+++ b/drivers/net/ipa/ipa_mem.c
@@ -160,13 +160,13 @@ int ipa_mem_config(struct ipa *ipa)
        mem_size = 8 * u32_get_bits(val, SHARED_MEM_SIZE_FMASK);
 
        /* If the sizes don't match, issue a warning */
-       if (ipa->mem_offset + mem_size > ipa->mem_size) {
-               dev_warn(dev, "ignoring larger reported memory size: 0x%08x\n",
-                       mem_size);
-       } else if (ipa->mem_offset + mem_size < ipa->mem_size) {
+       if (ipa->mem_offset + mem_size < ipa->mem_size) {
                dev_warn(dev, "limiting IPA memory size to 0x%08x\n",
                         mem_size);
                ipa->mem_size = mem_size;
+       } else if (ipa->mem_offset + mem_size > ipa->mem_size) {
+               dev_dbg(dev, "ignoring larger reported memory size: 0x%08x\n",
+                       mem_size);
        }
 
        /* Prealloc DMA memory for zeroing regions */
-- 
2.20.1

Reply via email to