Re: [PATCH net-next v3 03/15] net/smc: Add connection counters for links

[Jakub Kicinski]

On Sat,  7 Nov 2020 13:59:46 +0100 Karsten Graul wrote:
> +static inline void smc_switch_link_and_count(struct smc_connection *conn,
> +                                          struct smc_link *to_lnk)

Please avoid the use of static inline functions.

The compiler should inline this 3 instruction function anyway.

Please fix other instances in this submission as well.

> +{
> +     atomic_dec(&conn->lnk->conn_cnt);
> +     conn->lnk = to_lnk;
> +     atomic_inc(&conn->lnk->conn_cnt);
> +}