On Wed, 4 Nov 2020 22:34:27 -0800 Cong Wang wrote: > On Wed, Nov 4, 2020 at 4:39 PM Jakub Kicinski <k...@kernel.org> wrote: > > > > On Mon, 2 Nov 2020 22:12:43 +0200 Vlad Buslov wrote: > > > Allow user to request action terse dump with new flag value > > > TCA_FLAG_TERSE_DUMP. Only output essential action info in terse dump > > > (kind, > > > stats, index and cookie, if set by the user when creating the action). > > > This > > > is different from filter terse dump where index is excluded (filter can be > > > identified by its own handle). > > > > > > Move tcf_action_dump_terse() function to the beginning of source file in > > > order to call it from tcf_dump_walker(). > > > > > > Signed-off-by: Vlad Buslov <v...@buslov.dev> > > > Suggested-by: Jamal Hadi Salim <j...@mojatatu.com> > > > > Jiri, Cong, can I get an ack? > > > > The previous terse dump made sense because it fulfilled the need of > > an important user (OvS). IDK if this is as clear-cut, and I haven't > > followed the iproute2 thread closely enough, so please weigh in. > > Like I said in the previous discussion, I am not a fan of terse dump, > but before we have a better solution here, using this flag is probably > the best we have on the table, so at least for a temporary solution: > > Acked-by: Cong Wang <xiyou.wangc...@gmail.com>
Applied, thanks!
