On 05.11.2020 15:20, David Laight wrote: > From: Heiner Kallweit >> Sent: 05 November 2020 13:58 >> >> RTL8125B has same or similar short packet hw padding bug as RTL8168evl. >> The main workaround has been extended accordingly, however we have to >> disable also hw checksumming for short packets on affected new chip >> versions. Change the code in a way that in case of further affected >> chip versions we have to add them in one place only. > > Why not just disable hw checksumming for short packets on > all devices (that use this driver). > Thanks for the hint. Briefly thought about that too but then decided against it as I don't have performance figures. But if everybody is fine with it, then I'd be happy to simplify short packet handling in the described way (in a v2).
> It can't make much difference to the performance. > The lack of conditionals may even make it faster. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 > 1PT, UK > Registration No: 1397386 (Wales) > Heiner
