We should be using the multicast sync routines for the
multicast filters.

Fixes: 1800eee16676 ("net: ionic: Replace in_interrupt() usage.")
Signed-off-by: Shannon Nelson <snel...@pensando.io>
---
 drivers/net/ethernet/pensando/ionic/ionic_lif.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c 
b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index 28044240caf2..a58bb572b23b 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -1158,6 +1158,14 @@ static void ionic_dev_uc_sync(struct net_device *netdev, 
bool from_ndo)
 
 }
 
+static void ionic_dev_mc_sync(struct net_device *netdev, bool from_ndo)
+{
+       if (from_ndo)
+               __dev_mc_sync(netdev, ionic_ndo_addr_add, ionic_ndo_addr_del);
+       else
+               __dev_mc_sync(netdev, ionic_addr_add, ionic_addr_del);
+}
+
 static void ionic_set_rx_mode(struct net_device *netdev, bool from_ndo)
 {
        struct ionic_lif *lif = netdev_priv(netdev);
@@ -1189,7 +1197,7 @@ static void ionic_set_rx_mode(struct net_device *netdev, 
bool from_ndo)
        }
 
        /* same for multicast */
-       ionic_dev_uc_sync(netdev, from_ndo);
+       ionic_dev_mc_sync(netdev, from_ndo);
        nfilters = le32_to_cpu(lif->identity->eth.max_mcast_filters);
        if (netdev_mc_count(netdev) > nfilters) {
                rx_mode |= IONIC_RX_MODE_F_ALLMULTI;
-- 
2.17.1

Reply via email to