On Wed, 04 Nov 2020 13:56:09 -0800 drt wrote:
> On 2020-11-03 15:09, Jakub Kicinski wrote:
> > On Sat, 31 Oct 2020 04:46:45 -0500 Lijun Pan wrote:
> >> Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so
> >> linkwatch_event can run") introduced do_change_param_reset function to
> >> solve the rtnl lock issue. Majority of the code in
> >> do_change_param_reset
> >> duplicates do_reset. Also, we can handle the rtnl lock issue in
> >> do_reset
> >> itself. Hence merge do_change_param_reset back into do_reset to clean
> >> up
> >> the code.
> >>
> >> Fixes: b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so
> >> linkwatch_event can run")
> >> Signed-off-by: Lijun Pan <[email protected]>
> >
> > Applied, thanks!
>
> Hi Jakub,
>
> Thank you for applying this patch so promptly. However, I would like to
> ask that this patch be withdrawn.
>
> 1. It needs more time in testing.
> 2. There are a number of bug fix patches being tested. This patch would
> require rework of those patches.
> 3. As the lead maintainer for ibmvnic, I failed to communicate this to
> Lijun. I will do better going forward.
>
> Please revert this commit. We will resubmit this patch later.
>
> I sincerely apologize for any trouble this may have caused.
No worries, please just send a revert patch with this information in
the commit message, and I'll apply right away.
BTW feel free to send a note if you need more time to review a
particular patch. Because of the volume of patches we get, I try to
apply things after a day or two. Otherwise the queue gets unmanageable.
