On Wed, 04 Nov 2020, Andrew Lunn wrote: > On Wed, Nov 04, 2020 at 02:28:35PM +0000, Lee Jones wrote: > > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > > > On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function > > > > parameter or member 'ndev' not described in 'am65_cpsw_timer_set' > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function > > > > parameter or member 'est_new' not described in 'am65_cpsw_timer_set' > > > > > > > > Cc: "David S. Miller" <da...@davemloft.net> > > > > Cc: Jakub Kicinski <k...@kernel.org> > > > > Cc: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> > > > > Cc: "Gustavo A. R. Silva" <gustavo...@kernel.org> > > > > Cc: netdev@vger.kernel.org > > > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > > > > > > Reviewed-by: Andrew Lunn <and...@lunn.ch> > > > > > > I _think_ these have got missed so far in the various cleanup passes > > > because of missing COMPILE_TEST. I've been adding that as part of > > > fixing these warnings. When your respin, could you add that as well? > > > > Yes, no problem. > > > > Just for this symbol? > > Hi Lee > > I've not look at the Kbuild, but ideally so that all TI drivers get > built when COMPILE_TEST is true. > > And this probably needs to happen for any patch i added a Reviewed-by: > because i missed them as well. I'm using COMPILE_TEST but just for arm > and x86, where as i guess you are using more randconfig builds, or > less popular architectures?
I'm doing 'allmodconfig' builds for; arm, arm64, mips, ppc and x86. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
