On Wed, Nov 04, 2020 at 12:09:15PM +0100, Toke Høiland-Jørgensen wrote:
> > +usage()
> > +{
> > + cat <<EOF
> > +Usage: $0 [OPTIONS]
> > + -h | --help Show this usage info
> > + --no-libbpf build the package without libbpf
> > + --libbpf-dir=DIR build the package with self defined libbpf
> > dir
> > +EOF
> > + exit $1
> > +}
>
> This would be the only command line arg that configure takes; all other
> options are passed via the environment. I think we should be consistent
> here; and since converting the whole configure script is probably out of
> scope for this patch, why not just use the existing FORCE_LIBBPF
> variable?
Yes, converting the whole configure script should be split as another patch
work.
>
> I.e., FORCE_LIBBPF=on will fail if not libbpf is present,
> FORCE_LIBBPF=off will disable libbpf entirely, and if the variable is
> unset, libbpf will be used if found?
I like this one, with only one variable. I will check how to re-organize the
script.
>
> Alternatively, keep them as two separate variables (FORCE_LIBBPF and
> DISABLE_LIBBPF?). I don't have any strong preference as to which of
> those is best, but I think they'd both be more consistent with the
> existing configure script logic...
Please tell me if others have any other ideas.
Thanks
Hnagbin
