On Mon, 02 Nov 2020 14:58:08 -0800 Saeed Mahameed wrote: > On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote: > > This series contains updates to ice driver only. > > ... > > > Tony renames Flow Director functions to be more generic as their use > > is expanded. > > > > Real expands ntuple support to allow for mask values to be specified. > > This > > is done by implementing ACL filtering in HW. > > > > This is a lot of code with only 2 liner commit messages! > > Can you please shed more light on what user interface is being used to > program and manage those ACLs, i see it is ethtool from the code but > the cover letter and commit messages do not provide any information > about that. > > Also could you please explain what ethtool interfaces/commands are > being implemented, in the commit messages or cover letter, either is > fine.
Please remove the defensive programming checks, and preferably slim down the use of your special return codes.
