Hi Willem,
> -----Original Message-----
> From: Willem de Bruijn <willemdebruijn.ker...@gmail.com>
> Sent: Tuesday, November 3, 2020 11:26 PM
> To: George Cherian <gcher...@marvell.com>
> Cc: Network Development <netdev@vger.kernel.org>; linux-kernel <linux-
> ker...@vger.kernel.org>; Jakub Kicinski <k...@kernel.org>; David Miller
> <da...@davemloft.net>; Sunil Kovvuri Goutham
> <sgout...@marvell.com>; Linu Cherian <lcher...@marvell.com>;
> Geethasowjanya Akula <gak...@marvell.com>; masahi...@kernel.org
> Subject: Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health
> reporters for NPA
>
> On Tue, Nov 3, 2020 at 12:43 PM George Cherian <gcher...@marvell.com>
> wrote:
> >
> > Hi Willem,
> >
> >
> > > -----Original Message-----
> > > From: Willem de Bruijn <willemdebruijn.ker...@gmail.com>
> > > Sent: Tuesday, November 3, 2020 7:21 PM
> > > To: George Cherian <gcher...@marvell.com>
> > > Cc: Network Development <netdev@vger.kernel.org>; linux-kernel
> > > <linux- ker...@vger.kernel.org>; Jakub Kicinski <k...@kernel.org>;
> > > David Miller <da...@davemloft.net>; Sunil Kovvuri Goutham
> > > <sgout...@marvell.com>; Linu Cherian <lcher...@marvell.com>;
> > > Geethasowjanya Akula <gak...@marvell.com>; masahi...@kernel.org
> > > Subject: [EXT] Re: [net-next PATCH 2/3] octeontx2-af: Add devlink
> > > health reporters for NPA
> > >
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > --
> > > > > > static int rvu_devlink_info_get(struct devlink *devlink,
> > > > > > struct
> > > > > devlink_info_req *req,
> > > > > > struct netlink_ext_ack
> > > > > > *extack) { @@
> > > > > > -53,7 +483,8 @@ int rvu_register_dl(struct rvu *rvu)
> > > > > > rvu_dl->dl = dl;
> > > > > > rvu_dl->rvu = rvu;
> > > > > > rvu->rvu_dl = rvu_dl;
> > > > > > - return 0;
> > > > > > +
> > > > > > + return rvu_health_reporters_create(rvu);
> > > > >
> > > > > when would this be called with rvu->rvu_dl == NULL?
> > > >
> > > > During initialization.
> > >
> > > This is the only caller, and it is only reached if rvu_dl is non-zero.
> >
> > Did you mean to ask, where is it de-initialized?
> > If so, it should be done in rvu_unregister_dl() after freeing rvu_dl.
>
> No, I meant that rvu_health_reporters_create does not need an !rvu-
> >rvu_dl precondition test, as the only callers calls with with a non-zero
> rvu_dl.
Yes understood!!
Will fix in v2.
Thanks,
-George
